Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround to support Checklist tests that have a presentOnAdmissionI… #1835

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Workaround to support Checklist tests that have a presentOnAdmissionI… #1835

merged 1 commit into from
Sep 11, 2023

Conversation

dczulada
Copy link
Contributor

…ndicator valueset

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.48% 🎉

Comparison is base (e7289da) 96.24% compared to head (ea25d09) 96.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
+ Coverage   96.24%   96.72%   +0.48%     
==========================================
  Files         156      156              
  Lines        7050     7051       +1     
==========================================
+ Hits         6785     6820      +35     
+ Misses        265      231      -34
Files Changed Coverage Δ
lib/validators/checklist_criteria_validator.rb 94.68% <50.00%> (-1.02%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dczulada dczulada requested a review from luis1van August 28, 2023 13:33
@dczulada dczulada merged commit 52a5894 into master Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis1van luis1van luis1van approved these changes

Assignees

@luis1van luis1van

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dczulada @luis1van